-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/issue 8118 #8150
Fix/issue 8118 #8150
Conversation
There are two main changes in the model -> view relationship: 1. The model coming from the store becomes the only source of truth and the UI will only change when the model changes. This means that when another UI component from settings menu wants to change some setting it needs to update the model, not UI components directly. 2. When the store will provide a new model we will update only rows that are different in the current model.
Property bindings were added for showMessageLinksSwitch in order for it to change the checked state whenever previewableSites model has any item checked or displayChatImages setting is true.
Jenkins BuildsClick to see older builds (4)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just some minor improvements needed imho
Simplify if statement Co-authored-by: Lukáš Tinkl <lukast@status.im>
Group all common functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; although in general there's too much JS code :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job and courage, I remember it was messy in there.
There are two main changes in the model -> view relationship:
What does the PR do
Fixing bug #8118
Affected areas
Messaging settings view
Display message links preview in the chat
Save messaging settings to perssistancy
StatusQ checklist
Screenshot of functionality (including design for comparison)
Screen.Recording.2022-11-07.at.17.21.22.mov
Cool Spaceship Picture